Fix for lost connection infinite loop #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 1, 2012 09:28
…ame fashion as getAruments returns them.
…first item in the payload args to prevent an undefined index error.
…before giving up. Also supressed fwrite errors.
|
Awesome, thanks 👍. I actually fixed this a little differently here a while ago but haven't merged back my changes from our customisations. (:disappointed:) Anyway, more than happy to bring this across and in. Thanks again! |
chrisboulton
added a commit
that referenced
this pull request
Dec 29, 2012
Fix for lost connection infinite loop
|
No prob, glad to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to retry establishing a connection to redis when the connection is lost. I also placed a sleep for 1 second before attempting to re-establish a connection. Our error logs were logging large amounts of the following error fwrite(): send of 51 bytes failed with errno=32 Broken pipe.